Skip to content

[DEV-9303] Removed the positional arg tests in prep for dataclassy removal.#230

Merged
charlta merged 1 commit into
mainfrom
DEV-9303-remove-cim-positional-arg-tests
Jun 26, 2026
Merged

[DEV-9303] Removed the positional arg tests in prep for dataclassy removal.#230
charlta merged 1 commit into
mainfrom
DEV-9303-remove-cim-positional-arg-tests

Conversation

@charlta

@charlta charlta commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Just removes the positional arg tests for the CIM model classes. No actual source changes.

Test Steps

None.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary. Removed them instead...
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

- [ ] I have updated the changelog. No changes
- [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Non-breaking

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@charlta charlta marked this pull request as ready for review June 26, 2026 01:02
@charlta charlta requested review from Boris-Filin and chestm007 June 26, 2026 01:03
@charlta charlta merged commit 43e8408 into main Jun 26, 2026
8 checks passed
@charlta charlta deleted the DEV-9303-remove-cim-positional-arg-tests branch June 26, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant